Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Metal Armor Updates #55865

Merged
merged 13 commits into from
Mar 9, 2022
Merged

More Metal Armor Updates #55865

merged 13 commits into from
Mar 9, 2022

Conversation

Drew4484
Copy link
Contributor

@Drew4484 Drew4484 commented Mar 6, 2022 •
edited
Loading

Summary

Content "Further metal armor updates"

Purpose of change

Moves old chainmail towards obsoletion, replacing it with 'junkchain' on spawn lists. Minor changes to platemail allowing arms and legs to block.

Describe the solution

Changes old steel chainmail to budget steel 'junkchain', replaces chainmail on itemgroups to spawn 'junkchain'. Also adds BLOCK_WHILE_WORN to plate armor arms, legs, and suits.

Describe alternatives you've considered

None.

Testing

Junk items spawn correctly, block_while_worn is active for plate armor pieces.

Additional context

@github-actions github-actions bot added Json astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Mar 6, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 6, 2022
@Drew4484 Drew4484 marked this pull request as ready for review March 6, 2022 08:20
@Drew4484 Drew4484 marked this pull request as draft March 6, 2022 08:39
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 6, 2022
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Mar 6, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Mar 7, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Mar 7, 2022
@Drew4484 Drew4484 marked this pull request as ready for review March 7, 2022 07:42
bombasticSlacks
bombasticSlacks reviewed Mar 7, 2022
View reviewed changes
data/json/items/armor/arms_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/arms_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/boots.json Outdated Show resolved Hide resolved
data/json/items/armor/boots.json Show resolved Hide resolved
data/json/items/armor/gloves.json Outdated Show resolved Hide resolved
data/json/items/armor/gloves.json Show resolved Hide resolved
data/json/items/armor/hoods.json Outdated Show resolved Hide resolved
data/json/items/armor/hoods.json Show resolved Hide resolved
data/json/items/armor/legs_armor.json Outdated Show resolved Hide resolved
data/json/items/armor/legs_armor.json Show resolved Hide resolved
@github-actions github-actions bot added the [JSON] Changes (can be) made in JSON label Mar 8, 2022
@kevingranade kevingranade merged commit 39cd2e8 into CleverRaven:master Mar 9, 2022
@Drew4484 Drew4484 deleted the Metal-armor-updates branch March 10, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombasticSlacks bombasticSlacks bombasticSlacks left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drew4484 @bombasticSlacks @kevingranade